Commit c75e427d authored Oct 18, 2017 by Dan Carpenter Committed by David S. Miller Oct 20, 2017

tipc: checking for NULL instead of IS_ERR()



The tipc_alloc_conn() function never returns NULL, it returns error
pointers, so I have fixed the check.

Fixes: 14c04493 ("tipc: add ability to order and receive topology events in driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 6575f354

net/tipc/server.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -504,7 +504,7 @@ bool tipc_topsrv_kern_subscr(struct net *net, u32 port, u32 type,
		(u32 )&sub.usr_handle = port;

		con = tipc_alloc_conn(tipc_topsrv(net));
		if (!con)
		if (IS_ERR(con))
		return false;

		*conid = con->conid;