Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c6e83cac authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Rafael J. Wysocki
Browse files

PM / Domains: Fix unsafe iteration over modified list of device links 



pm_genpd_remove_subdomain() iterates over domain's master_links list and
removes matching element thus it has to use safe version of list
iteration.

Fixes: f721889f ("PM / Domains: Support for generic I/O PM domains (v8)")
Cc: 3.1+ <stable@vger.kernel.org> # 3.1+
Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Acked-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 8b55e55e

drivers/base/power/domain.c

+2 −2
Original line number Diff line number Diff line
@@ -1446,7 +1446,7 @@ EXPORT_SYMBOL_GPL(pm_genpd_add_subdomain); 
int pm_genpd_remove_subdomain(struct generic_pm_domain *genpd,

			      struct generic_pm_domain *subdomain)

{

	struct gpd_link *link;

	struct gpd_link *l, *link;

	int ret = -EINVAL;



	if (IS_ERR_OR_NULL(genpd) || IS_ERR_OR_NULL(subdomain))
@@ -1462,7 +1462,7 @@ int pm_genpd_remove_subdomain(struct generic_pm_domain *genpd, 
		goto out;

	}



	list_for_each_entry(link, &genpd->master_links, master_node) {

	list_for_each_entry_safe(link, l, &genpd->master_links, master_node) {

		if (link->slave != subdomain)

			continue;