Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c68b7f12 authored by Johan Hedberg's avatar Johan Hedberg Committed by Marcel Holtmann
Browse files

Bluetooth: Fix dereferencing conn variable before NULL check 



This patch fixes the following type of static analyzer warning (and
probably a real bug as well as the NULL check should be there for a
reason):

net/bluetooth/smp.c:1182 smp_conn_security() warn: variable dereferenced before check 'conn' (see line 1174)

Signed-off-by: default avatarJohan Hedberg <johan.hedberg@intel.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent 9f06a8d6

net/bluetooth/smp.c

+3 −1
Original line number Diff line number Diff line
@@ -1210,7 +1210,7 @@ static u8 smp_cmd_security_req(struct l2cap_conn *conn, struct sk_buff *skb) 
int smp_conn_security(struct hci_conn *hcon, __u8 sec_level)

{

	struct l2cap_conn *conn = hcon->l2cap_data;

	struct l2cap_chan *chan = conn->smp;

	struct l2cap_chan *chan;

	struct smp_chan *smp;

	__u8 authreq;

	int ret;
@@ -1221,6 +1221,8 @@ int smp_conn_security(struct hci_conn *hcon, __u8 sec_level) 
	if (!conn)

		return 1;



	chan = conn->smp;



	if (!test_bit(HCI_LE_ENABLED, &hcon->hdev->dev_flags))

		return 1;