Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c6463694 authored by Douglas Anderson's avatar Douglas Anderson Committed by Greg Kroah-Hartman
Browse files

soc: qcom: rpmh: Dirt can only make you dirtier, not cleaner 



commit 35bb4b22f606c0cc8eedf567313adc18161b1af4 upstream.

Adding an item into the cache should never be able to make the cache
cleaner.  Use "|=" rather than "=" to update the dirty flag.

Reviewed-by: default avatarMatthias Kaehlcke <mka@chromium.org>
Reviewed-by: Maulik Shah <mkshah@codeaurora.org> Thanks, Maulik
Reviewed-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Fixes: bb7000677a1b ("soc: qcom: rpmh: Update dirty flag only when data changes")
Reported-by: default avatarStephen Boyd <swboyd@chromium.org>
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20200417141531.1.Ia4b74158497213eabad7c3d474c50bfccb3f342e@changeid


Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 20b3a3df

drivers/soc/qcom/rpmh.c

+4 −4
Original line number Diff line number Diff line
@@ -150,7 +150,7 @@ static struct cache_req *cache_rpm_request(struct rpmh_ctrlr *ctrlr, 
		break;

	}



	ctrlr->dirty = (req->sleep_val != old_sleep_val ||

	ctrlr->dirty |= (req->sleep_val != old_sleep_val ||

			 req->wake_val != old_wake_val) &&

			 req->sleep_val != UINT_MAX &&

			 req->wake_val != UINT_MAX;