Commit c635df49 authored Mar 24, 2017 by Colin Ian King Committed by Mark Brown Mar 24, 2017

regulator: twl6030: remove redundant range check min_uV > 1300000 && min_uV <= 1350000



It has been pointed out to me that the range for vsel = 58 is actually
dead code as this is covered by an earlier check for (min_uV >= 700000)
&& (min_uV <= 1420000) so remove that check completely.

Reported-by: Alban Auzeill <alban.auzeill@sonarsource.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent d00b7461

drivers/regulator/twl6030-regulator.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -456,8 +456,6 @@ static int twl6030smps_map_voltage(struct regulator_dev *rdev, int min_uV,
		vsel = 60;
		else if ((min_uV > 1350000) && (min_uV <= 1500000))
		vsel = 59;
		else if ((min_uV > 1300000) && (min_uV <= 1350000))
		vsel = 58;
		else
		return -EINVAL;
		break;