Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c530e341 authored by Horia Geantă's avatar Horia Geantă Committed by Herbert Xu
Browse files

crypto: caam - fix smatch warnings 



Fix the following smatch warnings:

drivers/crypto/caam/caamalg.c:2350 aead_edesc_alloc() warn: we tested 'src_nents' before and it was 'true'
drivers/crypto/caam/caamrng.c:351 caam_rng_init() error: no modifiers for allocation.

Signed-off-by: default avatarHoria Geantă <horia.geanta@nxp.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 8439e94f

drivers/crypto/caam/caamalg.c

+1 −3
Original line number Diff line number Diff line
@@ -2346,10 +2346,8 @@ static struct aead_edesc *aead_edesc_alloc(struct aead_request *req, 


	/* Check if data are contiguous. */

	all_contig = !src_nents;

	if (!all_contig) {

		src_nents = src_nents ? : 1;

	if (!all_contig)

		sec4_sg_len = src_nents;

	}



	sec4_sg_len += dst_nents;

drivers/crypto/caam/caamrng.c

+1 −1
Original line number Diff line number Diff line
@@ -348,7 +348,7 @@ static int __init caam_rng_init(void) 
		pr_err("Job Ring Device allocation for transform failed\n");

		return PTR_ERR(dev);

	}

	rng_ctx = kmalloc(sizeof(*rng_ctx), GFP_DMA);

	rng_ctx = kmalloc(sizeof(*rng_ctx), GFP_DMA | GFP_KERNEL);

	if (!rng_ctx) {

		err = -ENOMEM;

		goto free_caam_alloc;