Commit c528eb27 authored Jun 01, 2017 by Richard Genoud Committed by Linus Walleij Jun 09, 2017

gpio: mvebu: fix blink counter register selection



The blink counter A was always selected because 0 was forced in the
blink select counter register.
The variable 'set' was obviously there to be used as the register value,
selecting the B counter when id==1 and A counter when id==0.

Tested on clearfog-pro (Marvell 88F6828)

Fixes: 757642f9 ("gpio: mvebu: Add limited PWM support")
Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Reviewed-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 0377f49f

drivers/gpio/gpio-mvebu.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -747,7 +747,7 @@ static int mvebu_pwm_probe(struct platform_device *pdev,
	set = U32_MAX;		set = U32_MAX;
	else		else
	return -EINVAL;		return -EINVAL;
	writel_relaxed(0, mvebu_gpioreg_blink_counter_select(mvchip));		writel_relaxed(set, mvebu_gpioreg_blink_counter_select(mvchip));

	mvpwm = devm_kzalloc(dev, sizeof(struct mvebu_pwm), GFP_KERNEL);		mvpwm = devm_kzalloc(dev, sizeof(struct mvebu_pwm), GFP_KERNEL);
	if (!mvpwm)		if (!mvpwm)