Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c523530c authored by AnilKumar Ch's avatar AnilKumar Ch Committed by Marc Kleine-Budde
Browse files

can: c_can: fix segfault during rmmod 



This patch fixes an oops which occurs during unloading the driver.
unregister_c_can_dev() is doing c_can/d_can module interrupts disable, which
requires module clock enable. c_can/d_can interrupts enable/disable is handled
properly in c_can_start and c_can_stop, so removing from
unregister_c_can_dev().

The problem was triggered by adding runtime PM support to the c_can driver by
this commit:

4cdd34b2 can: c_can: Add runtime PM support to Bosch C_CAN/D_CAN controller

Signed-off-by: default avatarAnilKumar Ch <anilkumar@ti.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 842b08bb

drivers/net/can/c_can/c_can.c

+0 −3
Original line number Diff line number Diff line
@@ -1265,9 +1265,6 @@ void unregister_c_can_dev(struct net_device *dev) 
{

	struct c_can_priv *priv = netdev_priv(dev);



	/* disable all interrupts */

	c_can_enable_all_interrupts(priv, DISABLE_ALL_INTERRUPTS);



	unregister_candev(dev);



	c_can_pm_runtime_disable(priv);