Commit c51b46dd authored Sep 20, 2017 by Colin Ian King Committed by Greg Kroah-Hartman Sep 22, 2017

staging: rtl8723bs: add missing range check on id



The value of the u8 id needs to be upper bounds checked to ensure
the cam_cache array on the adapter dvobj is not indexed outside
of the allowed range of 0..TOTAL_CAM_ENTRY-1. This can currently
occur if id is >= TOTAL_CAM_ENTRY when calling write_cam_from_cache.
Fix this by adding an upper range check.

Detected by CoverityScan, CID#1428464 ("Use of untrusted scalar value")

Fixes: 554c0a3a ("staging: Add rtl8723bs sdio wifi driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 974d4d03

drivers/staging/rtl8723bs/os_dep/rtw_proc.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -311,6 +311,8 @@ static ssize_t proc_set_cam(struct file file, const char __user buffer, size_t

		if (num < 2)
		return count;
		if (id >= TOTAL_CAM_ENTRY)
		return -EINVAL;

		if (strcmp("c", cmd) == 0) {
		_clear_cam_entry(adapter, id);