Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c4de6569 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

cpu/hotplug: Make bringup/teardown of smp threads symmetric 



The asymmetry caused a warning to trigger if the bootup was stopped in state
CPUHP_AP_ONLINE_IDLE. The warning no longer triggers as kthread_park() can
now be invoked on already or still parked threads. But there is still no
reason to have this be asymmetric.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Acked-by: default avatarIngo Molnar <mingo@kernel.org>
parent f048c399

kernel/cpu.c

+1 −2
Original line number Diff line number Diff line
@@ -754,7 +754,6 @@ static int takedown_cpu(unsigned int cpu) 


	/* Park the smpboot threads */

	kthread_park(per_cpu_ptr(&cpuhp_state, cpu)->thread);

	smpboot_park_threads(cpu);



	/*

	 * Prevent irq alloc/free while the dying cpu reorganizes the
@@ -1332,7 +1331,7 @@ static struct cpuhp_step cpuhp_hp_states[] = { 
	[CPUHP_AP_SMPBOOT_THREADS] = {

		.name			= "smpboot/threads:online",

		.startup.single		= smpboot_unpark_threads,

		.teardown.single	= NULL,

		.teardown.single	= smpboot_park_threads,

	},

	[CPUHP_AP_IRQ_AFFINITY_ONLINE] = {

		.name			= "irq/affinity:online",