Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c4c896e1 authored by Vasiliy Kulikov's avatar Vasiliy Kulikov Committed by Gustavo Padovan
Browse files

Bluetooth: sco: fix information leak to userspace 



struct sco_conninfo has one padding byte in the end.  Local variable
cinfo of type sco_conninfo is copied to userspace with this uninizialized
one byte, leading to old stack contents leak.

Signed-off-by: default avatarVasiliy Kulikov <segoon@openwall.com>
Signed-off-by: default avatarGustavo F. Padovan <padovan@profusion.mobi>
parent 43629f8f

net/bluetooth/sco.c

+1 −0
Original line number Diff line number Diff line
@@ -703,6 +703,7 @@ static int sco_sock_getsockopt_old(struct socket *sock, int optname, char __user 
			break;

		}



		memset(&cinfo, 0, sizeof(cinfo));

		cinfo.hci_handle = sco_pi(sk)->conn->hcon->handle;

		memcpy(cinfo.dev_class, sco_pi(sk)->conn->hcon->dev_class, 3);