Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c47bfd52 authored by Jordan Crouse's avatar Jordan Crouse
Browse files

msm: ipa: Fix compiler warnings 



Fix a few compiler warnings including an uninitalized variable and
several string format warnings.

Fixes: 859783a1 ("msm: ipa: Add snapshot of IPA driver")
Change-Id: Ic0dedbad9c36c58625d35f48cf49a983155e3729
Signed-off-by: default avatarJordan Crouse <jcrouse@codeaurora.org>
parent a38964b4

drivers/platform/msm/ipa/ipa_v3/ipa.c

+1 −1
Original line number Diff line number Diff line
@@ -4344,7 +4344,7 @@ static void ipa3_freeze_clock_vote_and_notify_modem(void) 
		return;



	if (IS_ERR(ipa3_ctx->smp2p_info.smem_state)) {

		IPAERR("fail to get smp2p clk resp bit %d\n",

		IPAERR("fail to get smp2p clk resp bit %ld\n",

			PTR_ERR(ipa3_ctx->smp2p_info.smem_state));

		return;

	}

drivers/platform/msm/ipa/ipa_v3/ipa_mhi.c

+2 −2
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-only

/*

 * Copyright (c) 2015-2018, The Linux Foundation. All rights reserved.

 * Copyright (c) 2015-2019, The Linux Foundation. All rights reserved.

 */



#include <linux/debugfs.h>
@@ -610,7 +610,7 @@ int ipa3_mhi_resume_channels_internal(enum ipa_client_type client, 
		res = gsi_read_channel_scratch(ep->gsi_chan_hdl,

			&gsi_ch_scratch);

		if (res) {

			IPA_MHI_ERR("read ch scratch fail %d %d\n", res);

			IPA_MHI_ERR("read ch scratch fail %d\n", res);

			return res;

		}

drivers/platform/msm/ipa/ipa_v3/ipa_utils.c

+1 −1
Original line number Diff line number Diff line
@@ -7611,7 +7611,7 @@ int emulator_load_fws( 
	 */

	if (phdr->p_memsz > gsi_ram_size) {

		IPAERR(

		    "Invalid GSI FW img size memsz=%d gsi_ram_size=%u\n",

		    "Invalid GSI FW img size memsz=%d gsi_ram_size=%lu\n",

		    phdr->p_memsz, gsi_ram_size);

		return -EINVAL;

	}

drivers/platform/msm/ipa/ipa_v3/ipahal/ipahal.c

+5 −5
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-only

/*

 * Copyright (c) 2016-2018, The Linux Foundation. All rights reserved.

 * Copyright (c) 2016-2019, The Linux Foundation. All rights reserved.

 */



#include <linux/debugfs.h>
@@ -1211,7 +1211,7 @@ static int ipahal_cp_proc_ctx_to_hw_buff_v3(enum ipa_hdr_proc_type type, 
		ctx->hdr_add.tlv.value = hdr_len;

		ctx->hdr_add.hdr_addr = is_hdr_proc_ctx ? phys_base :

			hdr_base_addr + offset_entry->offset;

		IPAHAL_DBG("header address 0x%x\n",

		IPAHAL_DBG("header address 0x%llx\n",

			ctx->hdr_add.hdr_addr);

		ctx->end.type = IPA_PROC_CTX_TLV_TYPE_END;

		ctx->end.length = 0;
@@ -1226,7 +1226,7 @@ static int ipahal_cp_proc_ctx_to_hw_buff_v3(enum ipa_hdr_proc_type type, 
		ctx->hdr_add.tlv.value = hdr_len;

		ctx->hdr_add.hdr_addr = is_hdr_proc_ctx ? phys_base :

			hdr_base_addr + offset_entry->offset;

		IPAHAL_DBG("header address 0x%x\n",

		IPAHAL_DBG("header address 0x%llx\n",

			ctx->hdr_add.hdr_addr);

		ctx->l2tp_params.tlv.type = IPA_PROC_CTX_TLV_TYPE_PROC_CMD;

		ctx->l2tp_params.tlv.length = 1;
@@ -1253,7 +1253,7 @@ static int ipahal_cp_proc_ctx_to_hw_buff_v3(enum ipa_hdr_proc_type type, 
		ctx->hdr_add.tlv.value = hdr_len;

		ctx->hdr_add.hdr_addr = is_hdr_proc_ctx ? phys_base :

			hdr_base_addr + offset_entry->offset;

		IPAHAL_DBG("header address 0x%x length %d\n",

		IPAHAL_DBG("header address 0x%llx length %d\n",

			ctx->hdr_add.hdr_addr, ctx->hdr_add.tlv.value);

		ctx->l2tp_params.tlv.type = IPA_PROC_CTX_TLV_TYPE_PROC_CMD;

		ctx->l2tp_params.tlv.length = 1;
@@ -1289,7 +1289,7 @@ static int ipahal_cp_proc_ctx_to_hw_buff_v3(enum ipa_hdr_proc_type type, 
		ctx->hdr_add.tlv.value = hdr_len;

		ctx->hdr_add.hdr_addr = is_hdr_proc_ctx ? phys_base :

			hdr_base_addr + offset_entry->offset;

		IPAHAL_DBG("header address 0x%x\n",

		IPAHAL_DBG("header address 0x%llx\n",

			ctx->hdr_add.hdr_addr);

		ctx->cmd.type = IPA_PROC_CTX_TLV_TYPE_PROC_CMD;

		ctx->cmd.length = 0;

drivers/platform/msm/ipa/ipa_v3/ipahal/ipahal_reg.c

+1 −1
Original line number Diff line number Diff line
@@ -3485,7 +3485,7 @@ void ipahal_get_aggr_force_close_valmask(int ep_idx, 
	struct ipahal_reg_valmask *valmask)

{

	u32 shft;

	u32 bmsk;

	u32 bmsk = 0;



	if (!valmask) {

		IPAHAL_ERR("Input error\n");