Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c472ab68 authored by Oliver Neukum's avatar Oliver Neukum Committed by David S. Miller
Browse files

cdc-ether: clean packet filter upon probe 



There are devices that don't do reset all the way. So the packet filter should
be set to a sane initial value. Failure to do so leads to intermittent failures
of DHCP on some systems under some conditions.

Signed-off-by: default avatarOliver Neukum <oneukum@suse.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 20fbe3ae

drivers/net/usb/cdc_ether.c

+16 −0
Original line number Diff line number Diff line
@@ -341,6 +341,22 @@ int usbnet_generic_cdc_bind(struct usbnet *dev, struct usb_interface *intf) 
		usb_driver_release_interface(driver, info->data);

		return -ENODEV;

	}



	/* Some devices don't initialise properly. In particular

	 * the packet filter is not reset. There are devices that

	 * don't do reset all the way. So the packet filter should

	 * be set to a sane initial value.

	 */

	usb_control_msg(dev->udev,

			usb_sndctrlpipe(dev->udev, 0),

			USB_CDC_SET_ETHERNET_PACKET_FILTER,

			USB_TYPE_CLASS | USB_RECIP_INTERFACE,

			USB_CDC_PACKET_TYPE_ALL_MULTICAST | USB_CDC_PACKET_TYPE_DIRECTED | USB_CDC_PACKET_TYPE_BROADCAST,

			intf->cur_altsetting->desc.bInterfaceNumber,

			NULL,

			0,

			USB_CTRL_SET_TIMEOUT

		);

	return 0;



bad_desc: