Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c44fccb5 authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Stephen Boyd
Browse files

clk: replace pr_warn() with pr_err() for fatal cases 



These three cases let clk_register() fail.  They should be considered
as error messages.

Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: default avatarVladimir Zapolskiy <vz@mleia.com>
Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
parent 3c436bf9

drivers/clk/clk.c

+5 −5
Original line number Diff line number Diff line
@@ -2320,14 +2320,14 @@ static int __clk_core_init(struct clk_core *core) 
	if (core->ops->set_rate &&

	    !((core->ops->round_rate || core->ops->determine_rate) &&

	      core->ops->recalc_rate)) {

		pr_warning("%s: %s must implement .round_rate or .determine_rate in addition to .recalc_rate\n",

		pr_err("%s: %s must implement .round_rate or .determine_rate in addition to .recalc_rate\n",

		       __func__, core->name);

		ret = -EINVAL;

		goto out;

	}



	if (core->ops->set_parent && !core->ops->get_parent) {

		pr_warning("%s: %s must implement .get_parent & .set_parent\n",

		pr_err("%s: %s must implement .get_parent & .set_parent\n",

		       __func__, core->name);

		ret = -EINVAL;

		goto out;
@@ -2335,7 +2335,7 @@ static int __clk_core_init(struct clk_core *core) 


	if (core->ops->set_rate_and_parent &&

			!(core->ops->set_parent && core->ops->set_rate)) {

		pr_warn("%s: %s must implement .set_parent & .set_rate\n",

		pr_err("%s: %s must implement .set_parent & .set_rate\n",

				__func__, core->name);

		ret = -EINVAL;

		goto out;