Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c42831c8 authored by Michał Kępień's avatar Michał Kępień Committed by Darren Hart
Browse files

dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request() 



An SMBIOS buffer pointer does not need to be returned by
dell_smbios_send_request(), because SMBIOS call results are stored in
the buffer exported by the module.

Signed-off-by: default avatarMichał Kępień <kernel@kempniu.pl>
Reviewed-by: default avatarPali Rohár <pali.rohar@gmail.com>
Signed-off-by: default avatarDarren Hart <dvhart@linux.intel.com>
parent 17070f24

drivers/platform/x86/dell-smbios.c

+1 −4
Original line number Diff line number Diff line
@@ -60,8 +60,7 @@ void dell_smbios_release_buffer(void) 
}

EXPORT_SYMBOL_GPL(dell_smbios_release_buffer);



struct calling_interface_buffer *

dell_smbios_send_request(int class, int select)

void dell_smbios_send_request(int class, int select)

{

	struct smi_cmd command;
@@ -75,8 +74,6 @@ dell_smbios_send_request(int class, int select) 
	buffer->select = select;



	dcdbas_smi_request(&command);



	return buffer;

}

EXPORT_SYMBOL_GPL(dell_smbios_send_request);

drivers/platform/x86/dell-smbios.h

+1 −2
Original line number Diff line number Diff line
@@ -41,8 +41,7 @@ extern struct calling_interface_token *da_tokens; 
void dell_smbios_get_buffer(void);

void dell_smbios_clear_buffer(void);

void dell_smbios_release_buffer(void);

struct calling_interface_buffer *

dell_smbios_send_request(int class, int select);

void dell_smbios_send_request(int class, int select);



int find_token_id(int tokenid);

int find_token_location(int tokenid);