Commit c4032994 authored Nov 13, 2020 by Mike Snitzer Committed by Greg Kroah-Hartman Dec 11, 2020

dm writecache: remove BUG() and fail gracefully instead



commit 857c4c0a8b2888d806f4308c58f59a6a81a1dee9 upstream.

Building on arch/s390/ results in this build error:

cc1: some warnings being treated as errors
../drivers/md/dm-writecache.c: In function 'persistent_memory_claim':
../drivers/md/dm-writecache.c:323:1: error: no return statement in function returning non-void [-Werror=return-type]

Fix this by replacing the BUG() with an -EOPNOTSUPP return.

Fixes: 48debafe ("dm: add writecache target")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 1d02176d

drivers/md/dm-writecache.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -318,7 +318,7 @@ static int persistent_memory_claim(struct dm_writecache *wc)
		#else
		static int persistent_memory_claim(struct dm_writecache *wc)
		{
		BUG();
		return -EOPNOTSUPP;
		}
		#endif