Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c3a0bbc7 authored by Adrian Hunter's avatar Adrian Hunter Committed by Arnaldo Carvalho de Melo
Browse files

perf auxtrace: Fix no_size logic in addr_filter__resolve_kernel_syms() 



Address filtering with kernel symbols incorrectly resulted in the error
"Cannot determine size of symbol" because the no_size logic was the wrong
way around.

Signed-off-by: default avatarAdrian Hunter <adrian.hunter@intel.com>
Tested-by: default avatarAndi Kleen <ak@linux.intel.com>
Cc: stable@vger.kernel.org # v4.9+
Link: http://lkml.kernel.org/r/1490357752-27942-1-git-send-email-adrian.hunter@intel.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent ef65e96e

tools/perf/util/auxtrace.c

+2 −2
Original line number Diff line number Diff line
@@ -1826,7 +1826,7 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt) 
		filt->addr = start;

		if (filt->range && !filt->size && !filt->sym_to) {

			filt->size = size;

			no_size = !!size;

			no_size = !size;

		}

	}
@@ -1840,7 +1840,7 @@ static int addr_filter__resolve_kernel_syms(struct addr_filter *filt) 
		if (err)

			return err;

		filt->size = start + size - filt->addr;

		no_size = !!size;

		no_size = !size;

	}



	/* The very last symbol in kallsyms does not imply a particular size */