Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c36ba80e authored by Bartlomiej Zolnierkiewicz's avatar Bartlomiej Zolnierkiewicz Committed by Ingo Molnar
Browse files

irq: Remove superfluous NULL pointer check in check_irq_resend() 



This takes care of the following entry from Dan's list:

kernel/irq/resend.c +73 check_irq_resend(17) warning: variable derefenced before check 'desc->chip'

Reported-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Eugene Teo <eteo@redhat.com>
Cc: Julia Lawall <julia@diku.dk>
LKML-Reference: <200908062146.03638.bzolnier@gmail.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 990a55eb

kernel/irq/resend.c

+1 −2
Original line number Diff line number Diff line
@@ -70,8 +70,7 @@ void check_irq_resend(struct irq_desc *desc, unsigned int irq) 
	if ((status & (IRQ_LEVEL | IRQ_PENDING | IRQ_REPLAY)) == IRQ_PENDING) {

		desc->status = (status & ~IRQ_PENDING) | IRQ_REPLAY;



		if (!desc->chip || !desc->chip->retrigger ||

					!desc->chip->retrigger(irq)) {

		if (!desc->chip->retrigger || !desc->chip->retrigger(irq)) {

#ifdef CONFIG_HARDIRQS_SW_RESEND

			/* Set it pending and activate the softirq: */

			set_bit(irq, irqs_resend);