Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c1ea0a04 authored by Guenter Roeck's avatar Guenter Roeck
Browse files

hwmon: (max6639) Introduce local dev variable, and reduce noisiness 



Introduce local variable 'dev' in probe function to make code easier
to read. Also drop dev_info message in probe to reduce noisiness
during boot.

Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Reviewed-by: default avatarJean Delvare <jdelvare@suse.de>
parent 71ba0f31

drivers/hwmon/max6639.c

+5 −7
Original line number Diff line number Diff line
@@ -545,11 +545,11 @@ static int max6639_detect(struct i2c_client *client, 
static int max6639_probe(struct i2c_client *client,

			 const struct i2c_device_id *id)

{

	struct device *dev = &client->dev;

	struct max6639_data *data;

	int err;



	data = devm_kzalloc(&client->dev, sizeof(struct max6639_data),

			    GFP_KERNEL);

	data = devm_kzalloc(dev, sizeof(struct max6639_data), GFP_KERNEL);

	if (!data)

		return -ENOMEM;
@@ -562,22 +562,20 @@ static int max6639_probe(struct i2c_client *client, 
		return err;



	/* Register sysfs hooks */

	err = sysfs_create_group(&client->dev.kobj, &max6639_group);

	err = sysfs_create_group(&dev->kobj, &max6639_group);

	if (err)

		return err;



	data->hwmon_dev = hwmon_device_register(&client->dev);

	data->hwmon_dev = hwmon_device_register(dev);

	if (IS_ERR(data->hwmon_dev)) {

		err = PTR_ERR(data->hwmon_dev);

		goto error_remove;

	}



	dev_info(&client->dev, "temperature sensor and fan control found\n");



	return 0;



error_remove:

	sysfs_remove_group(&client->dev.kobj, &max6639_group);

	sysfs_remove_group(&dev->kobj, &max6639_group);

	return err;

}