Commit c115add9 authored Jul 21, 2014 by Brian Norris

mtd: nand: denali: set proper error code on timeout



The condition "if (irq_status == 0)" already ensures that one half of
the ternary ?: is dead. I think this should probably actually be a FAIL,
not a PASS.

Caught by Coverity.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: Jamie Iles <jamie@jamieiles.com>

parent 31f75462

drivers/mtd/nand/denali.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -1062,9 +1062,7 @@ static int write_page(struct mtd_info mtd, struct nand_chip chip,
		dev_err(denali->dev,
		"timeout on write_page (type = %d)\n",
		raw_xfer);
		denali->status =
		(irq_status & INTR_STATUS__PROGRAM_FAIL) ?
		NAND_STATUS_FAIL : PASS;
		denali->status = NAND_STATUS_FAIL;
		}

		denali_enable_dma(denali, false);