Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c0664893 authored by Colin Ian King's avatar Colin Ian King Committed by Arnaldo Carvalho de Melo
Browse files

perf intel-pt: Fix off-by-one comparison on maximum code 



The check for the maximum code is off-by-one; the current comparison of
a code that is INTEL_PT_ERR_MAX will cause the strlcpy to perform an out
of bounds array access on the intel_pt_err_msgs array.

Fix this with a >= comparison.

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1461524203-10224-1-git-send-email-colin.king@canonical.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 73b1794e

tools/perf/util/intel-pt-decoder/intel-pt-decoder.c

+1 −1
Original line number Diff line number Diff line
@@ -356,7 +356,7 @@ static const char *intel_pt_err_msgs[] = { 


int intel_pt__strerror(int code, char *buf, size_t buflen)

{

	if (code < 1 || code > INTEL_PT_ERR_MAX)

	if (code < 1 || code >= INTEL_PT_ERR_MAX)

		code = INTEL_PT_ERR_UNK;

	strlcpy(buf, intel_pt_err_msgs[code], buflen);

	return 0;