Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c03ae533 authored by Florian Westphal's avatar Florian Westphal Committed by David S. Miller
Browse files

rxrpc: terminate retrans loop when sending of skb fails 



Typo, 'stop' is never set to true.
Seems intent is to not attempt to retransmit more packets after sendmsg
returns an error.

This change is based on code inspection only.

Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 56b08fdc

net/rxrpc/ar-ack.c

+4 −3
Original line number Diff line number Diff line
@@ -218,7 +218,8 @@ static void rxrpc_resend(struct rxrpc_call *call) 
	struct rxrpc_header *hdr;

	struct sk_buff *txb;

	unsigned long *p_txb, resend_at;

	int loop, stop;

	bool stop;

	int loop;

	u8 resend;



	_enter("{%d,%d,%d,%d},",
@@ -226,7 +227,7 @@ static void rxrpc_resend(struct rxrpc_call *call) 
	       atomic_read(&call->sequence),

	       CIRC_CNT(call->acks_head, call->acks_tail, call->acks_winsz));



	stop = 0;

	stop = false;

	resend = 0;

	resend_at = 0;
@@ -255,7 +256,7 @@ static void rxrpc_resend(struct rxrpc_call *call) 
			_proto("Tx DATA %%%u { #%d }",

			       ntohl(sp->hdr.serial), ntohl(sp->hdr.seq));

			if (rxrpc_send_packet(call->conn->trans, txb) < 0) {

				stop = 0;

				stop = true;

				sp->resend_at = jiffies + 3;

			} else {

				sp->resend_at =