Commit c012309a authored May 12, 2023 by Theodore Ts'o Committed by Greg Kroah-Hartman May 17, 2023

ext4: bail out of ext4_xattr_ibody_get() fails for any reason



commit 2a534e1d0d1591e951f9ece2fb460b2ff92edabd upstream.

In ext4_update_inline_data(), if ext4_xattr_ibody_get() fails for any
reason, it's best if we just fail as opposed to stumbling on,
especially if the failure is EFSCORRUPTED.

Cc: stable@kernel.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3d7b8fbc

fs/ext4/inline.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -358,7 +358,7 @@ static int ext4_update_inline_data(handle_t handle, struct inode inode,

		error = ext4_xattr_ibody_get(inode, i.name_index, i.name,
		value, len);
		if (error == -ENODATA)
		if (error < 0)
		goto out;

		BUFFER_TRACE(is.iloc.bh, "get_write_access");