Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bf80669e authored by David Ahern's avatar David Ahern Committed by Arnaldo Carvalho de Melo
Browse files

perf top: Make -g refer to callchains 



In most commands -g is used for callchains. Make perf-top follow suit.
Move group to just --group with no short cut making it similar to
perf-record.

Signed-off-by: default avatarDavid Ahern <dsahern@gmail.com>
Acked-by: default avatarIngo Molnar <mingo@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1384487490-6865-1-git-send-email-dsahern@gmail.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 15e65c69

tools/perf/Documentation/perf-top.txt

+2 −3
Original line number Diff line number Diff line
@@ -50,7 +50,6 @@ Default is to monitor all CPUS. 
--count-filter=<count>::

	Only display functions with more events than this.



-g::

--group::

        Put the counters into a counter group.
@@ -143,12 +142,12 @@ Default is to monitor all CPUS. 
--asm-raw::

	Show raw instruction encoding of assembly instructions.



-G::

-g::

	Enables call-graph (stack chain/backtrace) recording.



--call-graph::

	Setup and enable call-graph (stack chain/backtrace) recording,

	implies -G.

	implies -g.



--max-stack::

	Set the stack depth limit when parsing the callchain, anything

tools/perf/builtin-top.c

+2 −2
Original line number Diff line number Diff line
@@ -1084,7 +1084,7 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused) 
			    "dump the symbol table used for profiling"),

	OPT_INTEGER('f', "count-filter", &top.count_filter,

		    "only display functions with more events than this"),

	OPT_BOOLEAN('g', "group", &opts->group,

	OPT_BOOLEAN(0, "group", &opts->group,

			    "put the counters into a counter group"),

	OPT_BOOLEAN('i', "no-inherit", &opts->no_inherit,

		    "child tasks do not inherit counters"),
@@ -1105,7 +1105,7 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused) 
		   " abort, in_tx, transaction"),

	OPT_BOOLEAN('n', "show-nr-samples", &symbol_conf.show_nr_samples,

		    "Show a column with the number of samples"),

	OPT_CALLBACK_NOOPT('G', NULL, &top.record_opts,

	OPT_CALLBACK_NOOPT('g', NULL, &top.record_opts,

			   NULL, "enables call-graph recording",

			   &callchain_opt),

	OPT_CALLBACK(0, "call-graph", &top.record_opts,