Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bf2d0877 authored by Corey Minyard's avatar Corey Minyard
Browse files

ipmi:ssif: Add a module parm to specify that SMBus alerts don't work 



They are broken on some platforms, this gives people a chance to work
around it until the firmware is fixed.

Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
parent acbd9ae7

drivers/char/ipmi/ipmi_ssif.c

+8 −0
Original line number Diff line number Diff line
@@ -1136,6 +1136,10 @@ module_param_array(slave_addrs, int, &num_slave_addrs, 0); 
MODULE_PARM_DESC(slave_addrs,

		 "The default IPMB slave address for the controller.");



static bool alerts_broken;

module_param(alerts_broken, bool, 0);

MODULE_PARM_DESC(alerts_broken, "Don't enable alerts for the controller.");



/*

 * Bit 0 enables message debugging, bit 1 enables state debugging, and

 * bit 2 enables timing debugging.  This is an array indexed by
@@ -1582,6 +1586,10 @@ static int ssif_probe(struct i2c_client *client, const struct i2c_device_id *id) 
		ssif_info->global_enables |= IPMI_BMC_EVT_MSG_BUFF;

	}



	/* Some systems don't behave well if you enable alerts. */

	if (alerts_broken)

		goto found;



	msg[0] = IPMI_NETFN_APP_REQUEST << 2;

	msg[1] = IPMI_SET_BMC_GLOBAL_ENABLES_CMD;

	msg[2] = ssif_info->global_enables | IPMI_BMC_RCV_MSG_INTR;