Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bea7eafd authored by Omar Sandoval's avatar Omar Sandoval Committed by David Sterba
Browse files

Btrfs: fix incorrect {node,sector}size endianness from BTRFS_IOC_FS_INFO 



fs_info->super_copy->{node,sector}size are little-endian, but the ioctl
should return the values in native endianness. Use the cached values in
btrfs_fs_info instead. Found with sparse.

Fixes: 80a773fb ("btrfs: retrieve more info from FS_INFO ioctl")
Signed-off-by: default avatarOmar Sandoval <osandov@fb.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 5f14efd3

fs/btrfs/ioctl.c

+3 −3
Original line number Diff line number Diff line
@@ -2769,9 +2769,9 @@ static long btrfs_ioctl_fs_info(struct btrfs_fs_info *fs_info, 
	}

	mutex_unlock(&fs_devices->device_list_mutex);



	fi_args->nodesize = fs_info->super_copy->nodesize;

	fi_args->sectorsize = fs_info->super_copy->sectorsize;

	fi_args->clone_alignment = fs_info->super_copy->sectorsize;

	fi_args->nodesize = fs_info->nodesize;

	fi_args->sectorsize = fs_info->sectorsize;

	fi_args->clone_alignment = fs_info->sectorsize;



	if (copy_to_user(arg, fi_args, sizeof(*fi_args)))

		ret = -EFAULT;