Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit be7dcfb6 authored by Sagi Grimberg's avatar Sagi Grimberg Committed by Nicholas Bellinger
Browse files

iscsi-target: Don't over-allocate sendtargets text resp buffer 



No reason to allocate a buffer of size bigger than initiator
MaxRecvDataSegmentLength. Moreover, we need to respect initiator
MRDSL and not send a larger payload.

Signed-off-by: default avatarSagi Grimberg <sagig@mellanox.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent c1e34b64

drivers/target/iscsi/iscsi_target.c

+1 −1
Original line number Diff line number Diff line
@@ -3397,7 +3397,7 @@ iscsit_build_sendtargets_response(struct iscsi_cmd *cmd, 
	unsigned char buf[ISCSI_IQN_LEN+12]; /* iqn + "TargetName=" + \0 */

	unsigned char *text_in = cmd->text_in_ptr, *text_ptr = NULL;



	buffer_len = max(conn->conn_ops->MaxRecvDataSegmentLength,

	buffer_len = min(conn->conn_ops->MaxRecvDataSegmentLength,

			 SENDTARGETS_BUF_LIMIT);



	payload = kzalloc(buffer_len, GFP_KERNEL);