Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit be4c798a authored by Gerrit Renker's avatar Gerrit Renker
Browse files

dccp: Bug in initial acknowledgment number assignment 



Step 8.5 in RFC 4340 says for the newly cloned socket

           Initialize S.GAR := S.ISS,

but what in fact the code (minisocks.c) does is

           Initialize S.GAR := S.ISR,

which is wrong (typo?) -- fixed by the patch.

Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
parent 7deb0f85

net/dccp/minisocks.c

+4 −4
Original line number Diff line number Diff line
@@ -165,12 +165,12 @@ struct sock *dccp_create_openreq_child(struct sock *sk, 
		/* See dccp_v4_conn_request */

		newdmsk->dccpms_sequence_window = req->rcv_wnd;



		newdp->dccps_gar = newdp->dccps_isr = dreq->dreq_isr;

		dccp_update_gsr(newsk, dreq->dreq_isr);



		newdp->dccps_iss = dreq->dreq_iss;

		newdp->dccps_gar = newdp->dccps_iss = dreq->dreq_iss;

		dccp_update_gss(newsk, dreq->dreq_iss);



		newdp->dccps_isr = dreq->dreq_isr;

		dccp_update_gsr(newsk, dreq->dreq_isr);



		/*

		 * SWL and AWL are initially adjusted so that they are not less than

		 * the initial Sequence Numbers received and sent, respectively: