Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit be4a1559 authored by Subash Abhinov Kasiviswanathan's avatar Subash Abhinov Kasiviswanathan Committed by Sean Tranchetti
Browse files

drivers: rmnet_shs: Static analysis fixes 



Fixed potential issues found by static analysis.
Fixed Junk trace output

CR-Fixed: 2326419
Change-Id: Icf42f28b8e123e36af522eccef4b1e6aaa0bf001
Acked-by: default avatarRaul Martinez <mraul@qti.qualcomm.com>
Signed-off-by: default avatarSubash Abhinov Kasiviswanathan <subashab@codeaurora.org>
parent 65d902ec

drivers/rmnet/shs/rmnet_shs_main.c

+2 −2
Original line number Diff line number Diff line
@@ -452,6 +452,8 @@ void rmnet_shs_flush_node(struct rmnet_shs_skbn_s *node) 
	if (!node->skb_list.head)

		return;



	hash2stamp = rmnet_shs_form_hash(node->map_index,

					 map->len, node->skb_list.head->hash);

	trace_rmnet_shs_high(RMNET_SHS_FLUSH,

			     RMNET_SHS_FLUSH_NODE_START,

			     node->hash, hash2stamp,
@@ -459,8 +461,6 @@ void rmnet_shs_flush_node(struct rmnet_shs_skbn_s *node) 
			     node->skb_list.num_parked_bytes,

			     node, node->skb_list.head);



	hash2stamp = rmnet_shs_form_hash(node->map_index,

					 map->len, node->skb_list.head->hash);

	for ((skb = node->skb_list.head); skb != NULL; skb = nxt_skb) {



		nxt_skb = skb->next;

drivers/rmnet/shs/rmnet_shs_wq.c

+1 −1
Original line number Diff line number Diff line
@@ -808,7 +808,7 @@ u16 rmnet_shs_wq_find_cpu_to_move_flows(u16 current_cpu, 


	cur_cpu_list_p = &rx_flow_tbl_p->cpu_list[current_cpu];

	cur_cpu_rx_pps = cur_cpu_list_p->rx_pps;



	pps_uthresh = rmnet_shs_cpu_rx_max_pps_thresh[current_cpu];

	/* If we are already on a perf core and required pps is beyond

	 * beyond the capacity that even perf cores aren't sufficient

	 * there is nothing much we can do. So we will continue to let flows