Commit be30fc4b authored Nov 20, 2009 by Aguilar Pena, Leed Committed by Greg Kroah-Hartman Dec 11, 2009

USB: twl4030: Enable USB regulators before enabling USB charging



For TWL family of power management ICs, USB charging works only
when USB regulators are in enabled state: 3v1, 1v5, 1v8

On a USB cable attach, twl4030_phy_resume(twl) function enables
the regulators. Enable USB charging, only after all regulators
are enabled.

Its observed that enabling USB charging before regulators are
enabled, causes USB charging to fail.

Tested on: Zoom2: omap3430: ES3.1 + TWL5030
Needs T2-MADC and T2-BCI drivers which are still not upstreamed.

Signed-off-by: Moiz Sonasath <m-sonasath@ti.com>
Signed-off-by: Leed Aguilar <leed.aguilar@ti.com>
Acked-by: Vikram Pandita <vikram.pandita@ti.com>
Acked-by: Anand Gadiyar <gadiyar@ti.com>
Acked-by: Nishanth Menon <nm@ti.com>
Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent ec412b92

drivers/usb/otg/twl4030-usb.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -598,12 +598,12 @@ static irqreturn_t twl4030_usb_irq(int irq, void *_twl)
		* USB_LINK_VBUS state. musb_hdrc won't care until it
		* starts to handle softconnect right.
		*/
		twl4030charger_usb_en(status == USB_LINK_VBUS);

		if (status == USB_LINK_NONE)
		twl4030_phy_suspend(twl, 0);
		else
		twl4030_phy_resume(twl);

		twl4030charger_usb_en(status == USB_LINK_VBUS);
		}
		sysfs_notify(&twl->dev->kobj, NULL, "vbus");