Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit be0976be authored by Jeff Garzik's avatar Jeff Garzik Committed by Jeff Garzik
Browse files

[netdrvr] kill sync_irq-before-freq_irq pattern 



synchronize_irq() is superfluous when free_irq() call immediately follows it,
because free_irq() also does a synchronize_irq() call of its own.

Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent 28cd4289

drivers/net/8139cp.c

+0 −1
Original line number Diff line number Diff line
@@ -1213,7 +1213,6 @@ static int cp_close (struct net_device *dev) 


	spin_unlock_irqrestore(&cp->lock, flags);



	synchronize_irq(dev->irq);

	free_irq(dev->irq, dev);



	cp_free_rings(cp);

drivers/net/8139too.c

+0 −1
Original line number Diff line number Diff line
@@ -2231,7 +2231,6 @@ static int rtl8139_close (struct net_device *dev) 


	spin_unlock_irqrestore (&tp->lock, flags);



	synchronize_irq (dev->irq);	/* racy, but that's ok here */

	free_irq (dev->irq, dev);



	rtl8139_tx_clear (tp);

drivers/net/dl2k.c

+1 −1
Original line number Diff line number Diff line
@@ -1753,7 +1753,7 @@ rio_close (struct net_device *dev) 


	/* Stop Tx and Rx logics */

	writel (TxDisable | RxDisable | StatsDisable, ioaddr + MACCtrl);

	synchronize_irq (dev->irq);



	free_irq (dev->irq, dev);

	del_timer_sync (&np->timer);

drivers/net/pci-skeleton.c

+0 −1
Original line number Diff line number Diff line
@@ -1739,7 +1739,6 @@ static int netdrv_close (struct net_device *dev) 


	spin_unlock_irqrestore (&tp->lock, flags);



	synchronize_irq (dev->irq);

	free_irq (dev->irq, dev);



	netdrv_tx_clear (dev);

drivers/net/tsi108_eth.c

+0 −1
Original line number Diff line number Diff line
@@ -1437,7 +1437,6 @@ static int tsi108_close(struct net_device *dev) 
		dev_kfree_skb(skb);

	}



	synchronize_irq(data->irq_num);

	free_irq(data->irq_num, dev);



	/* Discard the RX ring. */