Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bd9fb1a4 authored by Scott Feldman's avatar Scott Feldman Committed by David S. Miller
Browse files

enic: record all bad FCS errs as frame errors 



Report all bad FCS errs as frames errs.  This includes frames with bad
FCS on wire detected by MAC and frames which may be truncated due to
ingress FIFO overruns.  No longer print a driver msg on bad FCS err.

Signed-off-by: default avatarScott Feldman <scofeldm@cisco.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ed8af6b2

drivers/net/enic/enic.h

+1 −0
Original line number Diff line number Diff line
@@ -97,6 +97,7 @@ struct enic { 
	____cacheline_aligned struct vnic_rq rq[1];

	unsigned int rq_count;

	int (*rq_alloc_buf)(struct vnic_rq *rq);

	u64 rq_bad_fcs;

	struct napi_struct napi;

	struct net_lro_mgr lro_mgr;

	struct net_lro_desc lro_desc[ENIC_LRO_MAX_DESC];

drivers/net/enic/enic_main.c

+3 −7
Original line number Diff line number Diff line
@@ -688,7 +688,7 @@ static struct net_device_stats *enic_get_stats(struct net_device *netdev) 
	net_stats->rx_bytes = stats->rx.rx_bytes_ok;

	net_stats->rx_errors = stats->rx.rx_errors;

	net_stats->multicast = stats->rx.rx_multicast_frames_ok;

	net_stats->rx_crc_errors = stats->rx.rx_crc_errors;

	net_stats->rx_crc_errors = enic->rq_bad_fcs;

	net_stats->rx_dropped = stats->rx.rx_no_bufs;



	return net_stats;
@@ -933,12 +933,8 @@ static void enic_rq_indicate_buf(struct vnic_rq *rq, 


	if (packet_error) {



		if (bytes_written > 0 && !fcs_ok) {

			if (net_ratelimit())

				printk(KERN_ERR PFX

					"%s: packet error: bad FCS\n",

					netdev->name);

		}

		if (bytes_written > 0 && !fcs_ok)

			enic->rq_bad_fcs++;



		dev_kfree_skb_any(skb);