Commit bd0d5aa4 authored Mar 05, 2012 by Jan Beulich Committed by Konrad Rzeszutek Wilk Mar 13, 2012

xenbus: don't free other end details too early

The individual drivers' remove functions could legitimately attempt to
access this information (for logging messages if nothing else). Note
that I did not in fact observe a problem anywhere, but I came across
this while looking into the reasons for what turned out to need the
fix at https://lkml.org/lkml/2012/3/5/336

 to vsprintf().

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

parent 73c154c6

drivers/xen/xenbus/xenbus_probe.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -257,11 +257,12 @@ int xenbus_dev_remove(struct device *_dev)
		DPRINTK("%s", dev->nodename);

		free_otherend_watch(dev);
		free_otherend_details(dev);

		if (drv->remove)
		drv->remove(dev);

		free_otherend_details(dev);

		xenbus_switch_state(dev, XenbusStateClosed);
		return 0;
		}