Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bd0bf577 authored by Pavel Emelyanov's avatar Pavel Emelyanov Committed by David S. Miller
Browse files

[IPV6]: Lost locking in fl6_sock_lookup 



This routine scans the ipv6_fl_list whose update is
protected with the socket lock and the ip6_sk_fl_lock.

Since the socket lock is not taken in the lookup, use
the other one.

Signed-off-by: default avatarPavel Emelyanov <xemul@openvz.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 04028045

net/ipv6/ip6_flowlabel.c

+3 −0
Original line number Diff line number Diff line
@@ -190,14 +190,17 @@ struct ip6_flowlabel * fl6_sock_lookup(struct sock *sk, __be32 label) 


	label &= IPV6_FLOWLABEL_MASK;



	read_lock_bh(&ip6_sk_fl_lock);

	for (sfl=np->ipv6_fl_list; sfl; sfl = sfl->next) {

		struct ip6_flowlabel *fl = sfl->fl;

		if (fl->label == label) {

			read_unlock_bh(&ip6_sk_fl_lock);

			fl->lastuse = jiffies;

			atomic_inc(&fl->users);

			return fl;

		}

	}

	read_unlock_bh(&ip6_sk_fl_lock);

	return NULL;

}