Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bcc54f9a authored by Dave Jones's avatar Dave Jones Committed by Jaroslav Kysela
Browse files

[ALSA] sound/isa/sb/sb_mixer.c double kfree 



Modules: SB drivers

snd_ctl_add() already does the free on error.

Coverity bug #957

Signed-off-by: default avatarDave Jones <davej@redhat.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent c27e8c59

sound/isa/sb/sb_mixer.c

+1 −3
Original line number Diff line number Diff line
@@ -453,10 +453,8 @@ int snd_sbmixer_add_ctl(struct snd_sb *chip, const char *name, int index, int ty 
	strlcpy(ctl->id.name, name, sizeof(ctl->id.name));

	ctl->id.index = index;

	ctl->private_value = value;

	if ((err = snd_ctl_add(chip->card, ctl)) < 0) {

		snd_ctl_free_one(ctl);

	if ((err = snd_ctl_add(chip->card, ctl)) < 0)

		return err;

	}

	return 0;

}