Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bbc33d05 authored by Oleg Nesterov's avatar Oleg Nesterov
Browse files

uprobes: Move __set_bit(UPROBE_SKIP_SSTEP) into alloc_uprobe() 



Cosmetic. __set_bit(UPROBE_SKIP_SSTEP) is the part of initialization,
it is not clear why it is set in insert_uprobe().

Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
Acked-by: default avatarSrikar Dronamraju <srikar@linux.vnet.ibm.com>
parent 661e5915

kernel/events/uprobes.c

+2 −3
Original line number Original line Diff line number Diff line
@@ -430,9 +430,6 @@ static struct uprobe *insert_uprobe(struct uprobe *uprobe) 
	u = __insert_uprobe(uprobe);

	u = __insert_uprobe(uprobe);

	spin_unlock(&uprobes_treelock);

	spin_unlock(&uprobes_treelock);





	/* For now assume that the instruction need not be single-stepped */

	__set_bit(UPROBE_SKIP_SSTEP, &uprobe->flags);



	return u;

	return u;

}

}
@@ -454,6 +451,8 @@ static struct uprobe *alloc_uprobe(struct inode *inode, loff_t offset) 
	uprobe->offset = offset;

	uprobe->offset = offset;

	init_rwsem(&uprobe->consumer_rwsem);

	init_rwsem(&uprobe->consumer_rwsem);

	mutex_init(&uprobe->copy_mutex);

	mutex_init(&uprobe->copy_mutex);

	/* For now assume that the instruction need not be single-stepped */

	__set_bit(UPROBE_SKIP_SSTEP, &uprobe->flags);





	/* add to uprobes_tree, sorted on inode:offset */

	/* add to uprobes_tree, sorted on inode:offset */

	cur_uprobe = insert_uprobe(uprobe);

	cur_uprobe = insert_uprobe(uprobe);