Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit bbba44bd authored Aug 30, 2019 by Petri Gynther Committed by Michael Bestas Nov 24, 2022

msm: cleanup: struct gsi_mhi_channel_scratch



Remove __packed from the usage of struct gsi_mhi_channel_scratch.
__packed is only needed in the struct definition and one union inclusion.

include/linux/msm_gsi.h:
struct __packed gsi_mhi_channel_scratch {
    ...
}

union __packed gsi_channel_scratch {
    ...
    struct __packed gsi_mhi_channel_scratch mhi;
    ...
}

Bug: 139442076
Bug: 139808631
Bug: 140528058
Change-Id: Ic07de9a164b88238bbe8655252b65783d846e933
Signed-off-by: Petri Gynther <pgynther@google.com>
(cherry picked from commit 43edfaab5f33aaa199f109e6c227221dbd13eac2)

parent 8fd6cf6c

drivers/platform/msm/gsi/gsi.c

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -2650,7 +2650,7 @@ static void __gsi_read_channel_scratch(unsigned long chan_hdl,
	}		}

	static union gsi_channel_scratch __gsi_update_mhi_channel_scratch(		static union gsi_channel_scratch __gsi_update_mhi_channel_scratch(
	unsigned long chan_hdl, struct __packed gsi_mhi_channel_scratch mscr)		unsigned long chan_hdl, struct gsi_mhi_channel_scratch mscr)
	{		{
	union gsi_channel_scratch scr;		union gsi_channel_scratch scr;

	@@ -2775,7 +2775,7 @@ int gsi_read_channel_scratch(unsigned long chan_hdl,
	EXPORT_SYMBOL(gsi_read_channel_scratch);		EXPORT_SYMBOL(gsi_read_channel_scratch);

	int gsi_update_mhi_channel_scratch(unsigned long chan_hdl,		int gsi_update_mhi_channel_scratch(unsigned long chan_hdl,
	struct __packed gsi_mhi_channel_scratch mscr)		struct gsi_mhi_channel_scratch mscr)
	{		{
	struct gsi_chan_ctx *ctx;		struct gsi_chan_ctx *ctx;

include/linux/msm_gsi.h

+2 −2

Original line number	Original line	Diff line number	Diff line
	@@ -1339,7 +1339,7 @@ int gsi_pending_irq_type(void);
	* @Return gsi_status		* @Return gsi_status
	*/		*/
	int gsi_update_mhi_channel_scratch(unsigned long chan_hdl,		int gsi_update_mhi_channel_scratch(unsigned long chan_hdl,
	struct __packed gsi_mhi_channel_scratch mscr);		struct gsi_mhi_channel_scratch mscr);

	/**		/**
	* gsi_start_channel - Peripheral should call this function to		* gsi_start_channel - Peripheral should call this function to
	@@ -1806,7 +1806,7 @@ static inline int gsi_pending_irq_type(void)
	}		}

	static inline int gsi_update_mhi_channel_scratch(unsigned long chan_hdl,		static inline int gsi_update_mhi_channel_scratch(unsigned long chan_hdl,
	struct __packed gsi_mhi_channel_scratch mscr)		struct gsi_mhi_channel_scratch mscr)
	{		{
	return -GSI_STATUS_UNSUPPORTED_OP;		return -GSI_STATUS_UNSUPPORTED_OP;
	}		}