Commit bbb27076 authored Apr 19, 2018 by Emil Tantilov Committed by Jeff Kirsher May 11, 2018

ixgbe: return error on unsupported SFP module when resetting



Add check for unsupported module and return the error code.
This fixes a Coverity hit due to unused return status from setup_sfp.

Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

parent ea3beca4

drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -3427,6 +3427,9 @@ static s32 ixgbe_reset_hw_X550em(struct ixgbe_hw *hw)
		hw->phy.sfp_setup_needed = false;
		}

		if (status == IXGBE_ERR_SFP_NOT_SUPPORTED)
		return status;

		/* Reset PHY */
		if (!hw->phy.reset_disable && hw->phy.ops.reset)
		hw->phy.ops.reset(hw);