Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bb649b34 authored by Roland Kammerer's avatar Roland Kammerer Committed by Jens Axboe
Browse files

lru_cache: Converted lc_seq_printf_status to return void 



Fix the semantic of lc_seq_printf. Currently, it always returns 0 and
the return value is unused, therefore, convert the return type to void.

Signed-off-by: default avatarPhilipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: default avatarLars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent 63a7c8ad

include/linux/lru_cache.h

+1 −1
Original line number Diff line number Diff line
@@ -264,7 +264,7 @@ extern unsigned int lc_put(struct lru_cache *lc, struct lc_element *e); 
extern void lc_committed(struct lru_cache *lc);



struct seq_file;

extern size_t lc_seq_printf_stats(struct seq_file *seq, struct lru_cache *lc);

extern void lc_seq_printf_stats(struct seq_file *seq, struct lru_cache *lc);



extern void lc_seq_dump_details(struct seq_file *seq, struct lru_cache *lc, char *utext,

				void (*detail) (struct seq_file *, struct lc_element *));

lib/lru_cache.c

+1 −3
Original line number Diff line number Diff line
@@ -238,7 +238,7 @@ void lc_reset(struct lru_cache *lc) 
 * @seq: the seq_file to print into

 * @lc: the lru cache to print statistics of

 */

size_t lc_seq_printf_stats(struct seq_file *seq, struct lru_cache *lc)

void lc_seq_printf_stats(struct seq_file *seq, struct lru_cache *lc)

{

	/* NOTE:

	 * total calls to lc_get are
@@ -250,8 +250,6 @@ size_t lc_seq_printf_stats(struct seq_file *seq, struct lru_cache *lc) 
	seq_printf(seq, "\t%s: used:%u/%u hits:%lu misses:%lu starving:%lu locked:%lu changed:%lu\n",

		   lc->name, lc->used, lc->nr_elements,

		   lc->hits, lc->misses, lc->starving, lc->locked, lc->changed);



	return 0;

}



static struct hlist_head *lc_hash_slot(struct lru_cache *lc, unsigned int enr)