Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bacb2d81 authored by Dan Carpenter's avatar Dan Carpenter Committed by Al Viro
Browse files

fs: add missing unlock in default_llseek() 



A recent change in linux-next, 982d8165 "fs: add SEEK_HOLE and
SEEK_DATA flags" added some direct returns on error, but it should
have been a goto out.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 750e0699

fs/read_write.c

+8 −4
Original line number Diff line number Diff line
@@ -166,8 +166,10 @@ loff_t default_llseek(struct file *file, loff_t offset, int origin) 
			 * long as offset isn't at the end of the file then the

			 * offset is data.

			 */

			if (offset >= inode->i_size)

				return -ENXIO;

			if (offset >= inode->i_size) {

				retval = -ENXIO;

				goto out;

			}

			break;

		case SEEK_HOLE:

			/*
@@ -175,8 +177,10 @@ loff_t default_llseek(struct file *file, loff_t offset, int origin) 
			 * as long as offset isn't i_size or larger, return

			 * i_size.

			 */

			if (offset >= inode->i_size)

				return -ENXIO;

			if (offset >= inode->i_size) {

				retval = -ENXIO;

				goto out;

			}

			offset = inode->i_size;

			break;

	}