Commit ba22a1e2 authored Sep 02, 2016 by Quentin Lambert Committed by Herbert Xu Sep 07, 2016

crypto: ccp - add missing release in ccp_dmaengine_register



ccp_dmaengine_register used to return with an error code before
releasing all resource. This patch adds a jump to the appropriate label
ensuring that the resources are properly released before returning.

This issue was found with Hector.

Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent ed4767d6

drivers/crypto/ccp/ccp-dmaengine.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -650,8 +650,11 @@ int ccp_dmaengine_register(struct ccp_device *ccp)
		dma_desc_cache_name = devm_kasprintf(ccp->dev, GFP_KERNEL,
		"%s-dmaengine-desc-cache",
		ccp->name);
		if (!dma_cmd_cache_name)
		return -ENOMEM;
		if (!dma_cmd_cache_name) {
		ret = -ENOMEM;
		goto err_cache;
		}

		ccp->dma_desc_cache = kmem_cache_create(dma_desc_cache_name,
		sizeof(struct ccp_dma_desc),
		sizeof(void *),