Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ba0a4e09 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

Bluetooth: sco: prevent information leak in sco_conn_defer_accept() 



[ Upstream commit 59da0b38bc2ea570ede23a3332ecb3e7574ce6b2 ]

Smatch complains that some of these struct members are not initialized
leading to a stack information disclosure:

    net/bluetooth/sco.c:778 sco_conn_defer_accept() warn:
    check that 'cp.retrans_effort' doesn't leak information

This seems like a valid warning.  I've added a default case to fix
this issue.

Fixes: 2f69a82a ("Bluetooth: Use voice setting in deferred SCO connection request")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent e5444d81

net/bluetooth/sco.c

+5 −0
Original line number Diff line number Diff line
@@ -761,6 +761,11 @@ static void sco_conn_defer_accept(struct hci_conn *conn, u16 setting) 
			cp.max_latency = cpu_to_le16(0xffff);

			cp.retrans_effort = 0xff;

			break;

		default:

			/* use CVSD settings as fallback */

			cp.max_latency = cpu_to_le16(0xffff);

			cp.retrans_effort = 0xff;

			break;

		}



		hci_send_cmd(hdev, HCI_OP_ACCEPT_SYNC_CONN_REQ,