Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b9eb3b14 authored by Dan Carpenter's avatar Dan Carpenter Committed by Martin K. Petersen
Browse files

scsi: aacraid: fix a signedness bug 



The problem is that ->reset_state is a u8 but it can be set to -1 or -2 in
aac_tmf_callback() and the error handling in aac_eh_target_reset() relies
on it to be signed.

[mkp: fixed typo]

Fixes: 0d643ff3 ("scsi: aacraid: use aac_tmf_callback for reset fib")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent d772a65d

drivers/scsi/aacraid/aacraid.h

+1 −1
Original line number Diff line number Diff line
@@ -1346,7 +1346,7 @@ struct fib { 
struct aac_hba_map_info {

	__le32	rmw_nexus;		/* nexus for native HBA devices */

	u8		devtype;	/* device type */

	u8		reset_state;	/* 0 - no reset, 1..x - */

	s8		reset_state;	/* 0 - no reset, 1..x - */

					/* after xth TM LUN reset */

	u16		qd_limit;

	u32		scan_counter;