Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b9e28d1f authored by James Hogan's avatar James Hogan Committed by Mauro Carvalho Chehab
Browse files

[media] rc: img-ir: hw: Fix min/max bits setup 



The calculated values for the minlen and maxlen fields, which were
rounded to multiples of 2 and clamped to a valid range, were left
unused. Use them in the calculation of the register value rather than
using the raw input minlen and maxlen.

This fixes the following warning with a W=1 build:
drivers/media/rc/img-ir/img-ir-hw.c In function ‘img_ir_free_timing’:
drivers/media/rc/img-ir/img-ir-hw.c +228 :23: warning: variable ‘maxlen’ set but not used [-Wunused-but-set-variable]
drivers/media/rc/img-ir/img-ir-hw.c +228 :15: warning: variable ‘minlen’ set but not used [-Wunused-but-set-variable]

Reported-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
Signed-off-by: default avatarJames Hogan <james.hogan@imgtec.com>
Signed-off-by: default avatarMauro Carvalho Chehab <m.chehab@samsung.com>
parent 32df34d8

drivers/media/rc/img-ir/img-ir-hw.c

+3 −3
Original line number Diff line number Diff line
@@ -240,8 +240,8 @@ static u32 img_ir_free_timing(const struct img_ir_free_timing *timing, 
	ft_min = (timing->ft_min*clock_hz + 999999) / 1000000;

	ft_min = (ft_min + 7) >> 3;

	/* construct register value */

	return	(timing->maxlen	<< IMG_IR_MAXLEN_SHIFT)	|

		(timing->minlen	<< IMG_IR_MINLEN_SHIFT)	|

	return	(maxlen << IMG_IR_MAXLEN_SHIFT)	|

		(minlen << IMG_IR_MINLEN_SHIFT)	|

		(ft_min << IMG_IR_FT_MIN_SHIFT);

}