Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b964c5ba authored by Simon Arlott's avatar Simon Arlott Committed by Jacek Anaszewski
Browse files

leds: bcm6328: Swap LED ON and OFF definitions 



The values of BCM6328_LED_MODE_ON and BCM6328_LED_MODE_OFF were named
for active low LEDs. These should be swapped so that they are named for
the default case of active high LEDs.

Signed-off-by: default avatarSimon Arlott <simon@fire.lp0.eu>
Signed-off-by: default avatarJacek Anaszewski <j.anaszewski@samsung.com>
parent 9d3c0663

drivers/leds/leds-bcm6328.c

+6 −6
Original line number Diff line number Diff line
@@ -48,10 +48,10 @@ 
					 BCM6328_SERIAL_LED_SHIFT_DIR)



#define BCM6328_LED_MODE_MASK		3

#define BCM6328_LED_MODE_OFF		0

#define BCM6328_LED_MODE_ON		0

#define BCM6328_LED_MODE_FAST		1

#define BCM6328_LED_MODE_BLINK		2

#define BCM6328_LED_MODE_ON		3

#define BCM6328_LED_MODE_OFF		3

#define BCM6328_LED_SHIFT(X)		((X) << 1)



/**
@@ -126,9 +126,9 @@ static void bcm6328_led_set(struct led_classdev *led_cdev, 
	*(led->blink_leds) &= ~BIT(led->pin);

	if ((led->active_low && value == LED_OFF) ||

	    (!led->active_low && value != LED_OFF))

		bcm6328_led_mode(led, BCM6328_LED_MODE_OFF);

	else

		bcm6328_led_mode(led, BCM6328_LED_MODE_ON);

	else

		bcm6328_led_mode(led, BCM6328_LED_MODE_OFF);

	spin_unlock_irqrestore(led->lock, flags);

}
@@ -303,8 +303,8 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg, 
			val = bcm6328_led_read(mode) >>

			      BCM6328_LED_SHIFT(shift % 16);

			val &= BCM6328_LED_MODE_MASK;

			if ((led->active_low && val == BCM6328_LED_MODE_ON) ||

			    (!led->active_low && val == BCM6328_LED_MODE_OFF))

			if ((led->active_low && val == BCM6328_LED_MODE_OFF) ||

			    (!led->active_low && val == BCM6328_LED_MODE_ON))

				led->cdev.brightness = LED_FULL;

			else

				led->cdev.brightness = LED_OFF;