Commit b92f4380 authored Jan 04, 2017 by Christophe Jaillet Committed by Thierry Reding Jan 25, 2017

memory: tegra: Add a missing 'of_node_put()' call



If 'of_find_device_by_node()' fails, an 'of_node_put()' call is missing in
the error handling path.
Fix it by reordering the code.

While at it, remove some empty lines in a more or less similar construction
a few lines below.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Thierry Reding <treding@nvidia.com>

parent 0c744ea4

drivers/memory/tegra/tegra124-emc.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -1115,11 +1115,10 @@ static int tegra_emc_probe(struct platform_device *pdev)
		}

		mc = of_find_device_by_node(np);
		of_node_put(np);
		if (!mc)
		return -ENOENT;

		of_node_put(np);

		emc->mc = platform_get_drvdata(mc);
		if (!emc->mc)
		return -EPROBE_DEFER;
		@@ -1135,9 +1134,7 @@ static int tegra_emc_probe(struct platform_device *pdev)
		}

		err = tegra_emc_load_timings_from_dt(emc, np);

		of_node_put(np);

		if (err)
		return err;