Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b91da88f authored by Linus Torvalds's avatar Linus Torvalds
Browse files

vfs: drop conditional inode prefetch in __do_lookup_rcu 



It seems to hurt performance in real life.  Yes, the inode will be used
later, but the conditional doesn't seem to predict all that well
(negative dentries are not uncommon) and it looks like the cost of
prefetching is simply higher than depending on the cache doing the right
thing.

As usual.

Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent b307d465

fs/dcache.c

+0 −2
Original line number Diff line number Diff line
@@ -1813,8 +1813,6 @@ struct dentry *__d_lookup_rcu(struct dentry *parent, struct qstr *name, 
		tname = dentry->d_name.name;

		i = dentry->d_inode;

		prefetch(tname);

		if (i)

			prefetch(i);

		/*

		 * This seqcount check is required to ensure name and

		 * len are loaded atomically, so as not to walk off the