Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b896fb35 authored by Dmitry V. Levin's avatar Dmitry V. Levin Committed by Al Viro
Browse files

vfs: show_vfsstat: remove redundant initialization and check of error code 



As err variable is now always checked right after each assignment, its
initialization is redundant and could be safely removed.  For the same
reason, the last check of err is also redundant and could be removed as
well.

Signed-off-by: default avatarDmitry V. Levin <ldv@altlinux.org>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 6ce4bca0

fs/proc_namespace.c

+2 −3
Original line number Original line Diff line number Diff line
@@ -193,7 +193,7 @@ static int show_vfsstat(struct seq_file *m, struct vfsmount *mnt) 
	struct mount *r = real_mount(mnt);

	struct mount *r = real_mount(mnt);

	struct path mnt_path = { .dentry = mnt->mnt_root, .mnt = mnt };

	struct path mnt_path = { .dentry = mnt->mnt_root, .mnt = mnt };

	struct super_block *sb = mnt_path.dentry->d_sb;

	struct super_block *sb = mnt_path.dentry->d_sb;

	int err = 0;

	int err;





	/* device */

	/* device */

	if (sb->s_op->show_devname) {

	if (sb->s_op->show_devname) {
@@ -222,7 +222,6 @@ static int show_vfsstat(struct seq_file *m, struct vfsmount *mnt) 
	/* optional statistics */

	/* optional statistics */

	if (sb->s_op->show_stats) {

	if (sb->s_op->show_stats) {

		seq_putc(m, ' ');

		seq_putc(m, ' ');

		if (!err)

		err = sb->s_op->show_stats(m, mnt_path.dentry);

		err = sb->s_op->show_stats(m, mnt_path.dentry);

	}

	}