Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b86e81d9 authored by Axel Lin's avatar Axel Lin Committed by Mark Brown
Browse files

spi: topcliff-pch: Properly unregister platform devices on probe() error paths 



Ensure all registered platform devices are unregistered on probe() error paths.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Signed-off-by: default avatarMark Brown <broonie@linaro.org>
parent c1b20aa5

drivers/spi/spi-topcliff-pch.c

+3 −2
Original line number Diff line number Diff line
@@ -1568,8 +1568,7 @@ static struct platform_driver pch_spi_pd_driver = { 
	.resume = pch_spi_pd_resume

};



static int pch_spi_probe(struct pci_dev *pdev,

				   const struct pci_device_id *id)

static int pch_spi_probe(struct pci_dev *pdev, const struct pci_device_id *id)

{

	struct pch_spi_board_data *board_dat;

	struct platform_device *pd_dev = NULL;
@@ -1639,6 +1638,8 @@ static int pch_spi_probe(struct pci_dev *pdev, 
	return 0;



err_platform_device:

	while (--i >= 0)

		platform_device_unregister(pd_dev_save->pd_save[i]);

	pci_disable_device(pdev);

pci_enable_device:

	pci_release_regions(pdev);