Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b86c8728 authored by Clemens Ladisch's avatar Clemens Ladisch Committed by Takashi Iwai
Browse files

sound: seq_midi: do not send MIDI reset when closing 



Sending a MIDI reset message when closing a port is wrong because we
only want to shut the device up, not to reset all settings.
Furthermore, many devices ignore this message.

Fortunately, the RawMIDI layer already shuts the device up, so we can
ignore this matter here.

Signed-off-by: default avatarClemens Ladisch <clemens@ladisch.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent f907ed94

sound/core/seq/seq_midi.c

+0 −3
Original line number Diff line number Diff line
@@ -249,12 +249,9 @@ static int midisynth_use(void *private_data, struct snd_seq_port_subscribe *info 
static int midisynth_unuse(void *private_data, struct snd_seq_port_subscribe *info)

{

	struct seq_midisynth *msynth = private_data;

	unsigned char buf = 0xff; /* MIDI reset */



	if (snd_BUG_ON(!msynth->output_rfile.output))

		return -EINVAL;

	/* sending single MIDI reset message to shut the device up */

	snd_rawmidi_kernel_write(msynth->output_rfile.output, &buf, 1);

	snd_rawmidi_drain_output(msynth->output_rfile.output);

	return snd_rawmidi_kernel_release(&msynth->output_rfile);

}